[asterisk-dev] [Code Review] inotify(7) support for pbx_spool

Tilghman Lesher tlesher at digium.com
Thu Mar 18 16:53:46 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/137/
-----------------------------------------------------------

(Updated 2010-03-18 16:53:46.467383)


Review request for Asterisk Developers.


Summary
-------

Instead of scanning the directory and trying to keep tabs on the mtime of the directory, an approach which has already been shown to have an issue with directory entry races, use the kernel builtin method of inotify(7) to identify every file as it gets created in the spool directory.


Diffs
-----

  /trunk/pbx/pbx_spool.c 253361 

Diff: https://reviewboard.asterisk.org/r/137/diff


Testing
-------

Compile-time testing only.


Thanks,

Tilghman




More information about the asterisk-dev mailing list