[asterisk-dev] [Code Review] Custom devstate for ConfBridge conferences

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/572/#review1699
-----------------------------------------------------------

Ship it!


Couple very minor points, but looks good to me.


trunk/CHANGES
<https://reviewboard.asterisk.org/r/572/#comment3783>

    Minor nit - Tack a period on the end of the second sentence.  Looks like the surrounding entries do.



trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/572/#comment3784>

    My only other comment is that we choose the name ('confbridge') carefully so that we don't end up wanting to change it later but having to keep it because of backwards compat.  I don't have a preference one way or another, just some food for thought.


- Sean


On 2010-03-17 15:54:49, Jared Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/572/
> -----------------------------------------------------------
> 
> (Updated 2010-03-17 15:54:49)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Joshua Colp.
> 
> 
> Summary
> -------
> 
> This patch adds custom device state handling for ConfBridge conferences, matching the devstate handling of the MeetMe conferences, as explained in bug #16972.
> 
> 
> This addresses bug 16972.
>     https://issues.asterisk.org/view.php?id=16972
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 253245 
>   trunk/apps/app_confbridge.c 253245 
> 
> Diff: https://reviewboard.asterisk.org/r/572/diff
> 
> 
> Testing
> -------
> 
> Added the patch, created a hint that referenced the custom devstate for a ConfBridge conference.  Checked the status of the hint using "core show hints" CLI command before, during, and after the audio conference.
> 
> 
> Thanks,
> 
> Jared
> 
>