[asterisk-dev] [Code Review] Allow configuration of minsecs and nextaftercmd per mailbox

Jeff Peeler jpeeler at digium.com
Wed Mar 17 12:41:34 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/555/
-----------------------------------------------------------

(Updated 2010-03-17 12:41:34.034468)


Review request for Asterisk Developers.


Changes
-------

Add some braces and remove all gotos as one parse failure does not prohibit the rest of the tests from running.


Summary
-------

Make this work in voicemail.conf:

[default]
1234 => 4242,Example Mailbox,imapuser at localhost,,minsecs=5|nextaftercmd=yes


This addresses bug 16864.
    https://issues.asterisk.org/view.php?id=16864


Diffs (updated)
-----

  /trunk/apps/app_voicemail.c 253202 

Diff: https://reviewboard.asterisk.org/r/555/diff


Testing
-------

Tested both options to ensure they were respected and have also created a unit test that checks to see if the vm_user struct is populated correctly (I guess it'll protect against accidental deletions or typos).


Thanks,

Jeff




More information about the asterisk-dev mailing list