[asterisk-dev] [Code Review] Mask arguments of previous invocations of Gosub

[Mark Michelson]

> On 2010-03-16 18:20:29, Russell Bryant wrote:
> > /trunk/tests/test_gosub.c, line 23
> > <https://reviewboard.asterisk.org/r/561/diff/1/?file=8698#file8698line23>
> >
> >     I don't think the verbatim stuff is needed

The verbatim stuff needs to be removed from test_skel.c and app_skel.c. That's why so many people include this when submitting new code.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/561/#review1692
-----------------------------------------------------------


On 2010-03-16 17:45:49, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/561/
> -----------------------------------------------------------
> 
> (Updated 2010-03-16 17:45:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The current behavior of Gosub is that it does not mask out previous arguments.  The problem with this is that for any subroutine with optional arguments, arguments from previous stack levels could influence how the newest stack level executes.
> 
> 
> This addresses bug 16758.
>     https://issues.asterisk.org/view.php?id=16758
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_stack.c 252838 
>   /trunk/tests/test_gosub.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/561/diff
> 
> 
> Testing
> -------
> 
> Unit test written that verifies this new behavior, as well as verifying several other behaviors of the Gosub suite of applications.
> 
> 
> Thanks,
> 
> Tilghman
> 
>