[asterisk-dev] [Code Review] Mask arguments of previous invocations of Gosub

Tilghman Lesher tlesher at digium.com
Tue Mar 16 17:45:49 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/561/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

The current behavior of Gosub is that it does not mask out previous arguments.  The problem with this is that for any subroutine with optional arguments, arguments from previous stack levels could influence how the newest stack level executes.


This addresses bug 16758.
    https://issues.asterisk.org/view.php?id=16758


Diffs
-----

  /trunk/apps/app_stack.c 252838 
  /trunk/tests/test_gosub.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/561/diff


Testing
-------

Unit test written that verifies this new behavior, as well as verifying several other behaviors of the Gosub suite of applications.


Thanks,

Tilghman




More information about the asterisk-dev mailing list