[asterisk-dev] [Code Review] Fix time test on platforms without inotify
Russell Bryant
russell at digium.com
Tue Mar 16 14:12:39 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/554/#review1682
-----------------------------------------------------------
Ship it!
Assuming the ast_log() is no longer needed, I'm good with this now.
/trunk/tests/test_time.c
<https://reviewboard.asterisk.org/r/554/#comment3760>
So this can just be removed?
- Russell
On 2010-03-16 12:18:16, Tilghman Lesher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/554/
> -----------------------------------------------------------
>
> (Updated 2010-03-16 12:18:16)
>
>
> Review request for Asterisk Developers and Russell Bryant.
>
>
> Summary
> -------
>
> Time test currently fails on non-Linux platforms, such as Mac OS X.
>
>
> Diffs
> -----
>
> /trunk/include/asterisk/localtime.h 252526
> /trunk/main/stdtime/localtime.c 252526
> /trunk/tests/test_time.c 252526
>
> Diff: https://reviewboard.asterisk.org/r/554/diff
>
>
> Testing
> -------
>
> Verified to work correctly on both Linux and Mac OS X (competing implementations).
>
>
> Thanks,
>
> Tilghman
>
>
More information about the asterisk-dev
mailing list