[asterisk-dev] [Code Review] Allow configuration of minsecs and nextaftercmd per mailbox

[Jeff Peeler]

> On 2010-03-16 13:30:25, Tilghman Lesher wrote:
> > /trunk/apps/app_voicemail.c, lines 10262-10269
> > <https://reviewboard.asterisk.org/r/555/diff/2/?file=8594#file8594line10262>
> >
> >     There doesn't appear to be a good reason for the goto's in this block.  Once a condition succeeds, it's going to go to the same place as the goto target (other than the IMAP stuff, which can be avoided by moving it to the top of the series).

What do you think about just removing all the gotos?


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/555/#review1680
-----------------------------------------------------------


On 2010-03-16 13:08:15, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/555/
> -----------------------------------------------------------
> 
> (Updated 2010-03-16 13:08:15)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Make this work in voicemail.conf:
> 
> [default]
> 1234 => 4242,Example Mailbox,imapuser at localhost,,minsecs=5|nextaftercmd=yes
> 
> 
> This addresses bug 16864.
>     https://issues.asterisk.org/view.php?id=16864
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 252758 
> 
> Diff: https://reviewboard.asterisk.org/r/555/diff
> 
> 
> Testing
> -------
> 
> Tested both options to ensure they were respected and have also created a unit test that checks to see if the vm_user struct is populated correctly (I guess it'll protect against accidental deletions or typos).
> 
> 
> Thanks,
> 
> Jeff
> 
>