[asterisk-dev] [Code Review] Fix time test on platforms without inotify

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/554/#review1676
-----------------------------------------------------------



/trunk/main/stdtime/localtime.c
<https://reviewboard.asterisk.org/r/554/#comment3751>

    I'd like to see an implementation that guarantees that the intended side effect of this function has occurred.  It looks like this is supposed to cause read() to break out, but there is no guarantee that the loop is sleeping in read() at this point.  Also, usleep() doesn't guarantee anything here, either.



/trunk/tests/test_time.c
<https://reviewboard.asterisk.org/r/554/#comment3750>

    I'm not really comfortable with the test unless we can fully explain it and its results are predictable.  This needs some more investigation.


- Russell


On 2010-03-15 16:50:08, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/554/
> -----------------------------------------------------------
> 
> (Updated 2010-03-15 16:50:08)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Time test currently fails on non-Linux platforms, such as Mac OS X.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/localtime.h 252526 
>   /trunk/main/stdtime/localtime.c 252526 
>   /trunk/tests/test_time.c 252526 
> 
> Diff: https://reviewboard.asterisk.org/r/554/diff
> 
> 
> Testing
> -------
> 
> Verified to work correctly on both Linux and Mac OS X (competing implementations).
> 
> 
> Thanks,
> 
> Tilghman
> 
>