[asterisk-dev] [Code Review] Generic Advice of Charge

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/552/
-----------------------------------------------------------

(Updated 2010-03-12 14:51:05.608852)


Review request for Asterisk Developers.


Changes
-------

update to reflect Russell's comments


Summary
-------

This review represents the AOC additions listed below.  The chan_dahdi component will be updated in this review once it is complete.  I thought it would be useful to get some feedback on my Generic AOC design while I work on the other components.

Current Additions:
- Generic AOC encode/decode routines. (Generic AOC must be encoded to be passed on the wire in the AST_CONTROL_AOC frame)
- AST_CONTROL_AOC frame type to represent generic encoded AOC data
- AOCMessage manager action for generating an AOC message on a channel
- SIP sending generic AOC-D messages to snom phones via the snom AOC specification. AOC-E can be sent as well, but currently only on an SIP_INFO message just like the AOC-D messages.
- Creation of chan_sip page3 flags for the addition of the new 'snom_aoc_enabled' sip.conf option.
- AOC message generating unit test


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 252079 
  /trunk/channels/sip/include/sip.h 252079 
  /trunk/configs/sip.conf.sample 252079 
  /trunk/include/asterisk/aoc.h PRE-CREATION 
  /trunk/include/asterisk/frame.h 252079 
  /trunk/main/aoc.c PRE-CREATION 
  /trunk/main/channel.c 252079 
  /trunk/main/manager.c 252079 
  /trunk/tests/test_aoc.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/552/diff


Testing
-------

I tested generating multiple combinations of AOC-E and AOC-D messages using the AOCMessage manager action.  These messages were queued onto a sip channel and forwarded to a snom phone where I could view the AOC results on the display.

I also developed an AOC unit test which I verified passes.


Thanks,

David