[asterisk-dev] [Code Review] Fix XML documentation on non-Linux platforms.

[Sean Bright]

> On 2010-03-10 08:28:12, Sean Bright wrote:
> > /trunk/main/xmldoc.c, line 1887
> > <https://reviewboard.asterisk.org/r/536/diff/2/?file=8513#file8513line1887>
> >
> >     Question... can legitimate file names have spaces in them?
> 
> Mark Michelson wrote:
>     I suppose they could since the astdatadir is completely user-configurable.
> 
> Sean Bright wrote:
>     Well then we need to use a linked list or array.
> 
> Nick Lewis wrote:
>     Or put the filenames (or the ones with spaces) in quotes? There is already an asterisk function get_in_brackets() that finds brackets only outside quotes so perhaps this code could be lifted to find spaces only outside quotes

No, there is no reason to make it that complicated.  We'll just use a list.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/536/#review1648
-----------------------------------------------------------


On 2010-03-09 16:17:14, Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/536/
> -----------------------------------------------------------
> 
> (Updated 2010-03-09 16:17:14)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Solaris glob() doesn't support GLOB_BRACE, so XML documentation wasn't being loaded.  Instead, let's switch to a slow and stupid method.
> 
> 
> This addresses bug 16688.
>     https://issues.asterisk.org/view.php?id=16688
> 
> 
> Diffs
> -----
> 
>   /trunk/main/xmldoc.c 251533 
> 
> Diff: https://reviewboard.asterisk.org/r/536/diff
> 
> 
> Testing
> -------
> 
> Documentation still loads as expected on Linux.
> 
> 
> Thanks,
> 
> Jason
> 
>