[asterisk-dev] [Code Review] PITCH_SHIFT dialplan function

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/526/
-----------------------------------------------------------

(Updated 2010-03-05 00:00:38.033557)


Review request for Asterisk Developers and Russell Bryant.


Changes
-------

Update
- PITCH_SHIFT(both) option for applying effect to both channels
- ENUM for recommended high and low values
- fixes most coding guideline issues
- fixes memory leak in write function
- Reverse TX and RX interpretation to match how these terms are most commonly used within the rest of Asterisk.


Summary
-------

The PITCH_SHIFT function can be used on a channel to independently modify the pitch of both rx and tx audio streams.  Now you can improve your conference calls by assigning a random pitch effect to everyone entering a meetme room, or just make your day more interesting by making your co-workers sound funny!  There are so many practical uses for this function :)


Diffs (updated)
-----

  /trunk/funcs/func_pitchshift.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/526/diff


Testing (updated)
-------

I've tested it with various configurations and it works.  Note that extreme high and low values can distort the voice to a point where it can no long be understood.  I have added some enum values as guideline of what bounds seem to work best for me.

For lowering the voice experiment with the values
PITCH_SHIFT(both)=low
PITCH_SHIFT(both)=lower
PITCH_SHIFT(both)=lowest

For raising the voice experiment with the values
PITCH_SHIFT(both)=high
PITCH_SHIFT(both)=higher
PITCH_SHIFT(both)=highest

Have fun! :)


Thanks,

David