[asterisk-dev] [Code Review] ETSI Advice Of Charge (AOC) event reporting. (libpri component)

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/538/#review1635
-----------------------------------------------------------

Ship it!


Great Work, This looks ready to go to me! The design is in line with my understanding of the ETSI AOC standard and I have reviewed this code for any obvious logic problems.

- David


On 2010-03-02 14:57:06, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/538/
> -----------------------------------------------------------
> 
> (Updated 2010-03-02 14:57:06)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This feature passes ETSI AOC-S, AOC-D, and AOC-E message information to the upper layer (i.e. Asterisk) for processing.
> 
> Relevant specification: EN 300 182
> 
> This is based off of the team/rmudgett/ect branch which is based off of the team/group/ccss branch to get the accumulated features so far.
> 
> The Asterisk portion of this review is located in review:
> https://reviewboard.asterisk.org/r/537/
> 
> As a side note:  Consideration was made for the possible future addition of Q.SIG AOC support (ECMA-212) with the events passed to the upper layer.
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/ect/Makefile 1510 
>   /team/rmudgett/ect/libpri.h 1510 
>   /team/rmudgett/ect/pri_aoc.c PRE-CREATION 
>   /team/rmudgett/ect/pri_facility.h 1510 
>   /team/rmudgett/ect/pri_facility.c 1510 
>   /team/rmudgett/ect/pri_internal.h 1510 
> 
> Diff: https://reviewboard.asterisk.org/r/538/diff
> 
> 
> Testing
> -------
> 
> Created a modified version of libpri that generated many canned AOC messages when a call gets connected.  The results are part of the Asterisk component of the review.
> 
> 
> Thanks,
> 
> rmudgett
> 
>