[asterisk-dev] [Code Review] Out-of-tree modules can fail because of compiler flag differences.

[Kevin P. Fleming]

Jason Parker wrote:

> This could get tricky.  You have to remember that nearly all of these 
> functions were static inline in lock.h, in the non-DEBUG_THREADS case.  
> Out-of-tree modules would likely contain a copy (really, dozens of copies).

Right, which would then mean that they don't have references to any core
copies of those functions. Anything that was 'static inline' before is
not a concern.

> I'm not very familiar with how to compiler does things.  Would those 
> inlined functions *actually* get called by the module, or would it have 
> literally replaced the function call with the code inside it?  I believe 
> the answer is mostly the latter, but generally "It depends."

The only functions that this applies to are those that were not
'static', which is probably just the ao2 functions.

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
skype: kpfleming | jabber: kfleming at digium.com
Check us out at www.digium.com & www.asterisk.org