[asterisk-dev] [Code Review] app_directory, support option 'p(n)' as documented with CLI online help, branches 1.6.1 to trunk.

Alec Davis sivad.a at paradise.net.nz
Mon Mar 1 15:59:00 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/481/
-----------------------------------------------------------

(Updated 2010-03-01 15:59:00.387939)


Review request for Asterisk Developers.


Changes
-------

In production with previous changes, the next item wasn't made available.


Summary
-------

finish off preliminary work done for initial pause before presenting directory name to caller.

Currently, 'core show application DIRECTORY' from 1.6.1 through to trunk indicates the 'p(n)' option is available, where in fact there is no code to act on it, other than to populate opts[OPT_ARG_PAUSE].


This addresses bug 16751.
    https://issues.asterisk.org/view.php?id=16751


Diffs (updated)
-----

  trunk/apps/app_directory.c 249675 

Diff: https://reviewboard.asterisk.org/r/481/diff


Testing
-------

1.6.1 production server.
'p' on it own doesn't introduce delay, as expected.
'p(1000)' introduces 1 second delay after intial 3 letters are entered, then presents names individually.
'mp(1000)' introduces 1 second delay after intial 3 letters are entered, then presents names as a list.
'p(6000)' enforces a maximum of a 3 second delay.


Thanks,

Alec




More information about the asterisk-dev mailing list