[asterisk-dev] [Code Review] code cleanup in app_senddtmf

Mark Michelson mmichelson at digium.com
Fri Jan 22 12:01:13 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/473/#review1393
-----------------------------------------------------------

Ship it!


Looks good. Thanks!

- Mark


On 2010-01-22 11:35:45, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/473/
> -----------------------------------------------------------
> 
> (Updated 2010-01-22 11:35:45)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> pushing changes/cleanup done when this was implemented in app_externalivr back in to app_senddtmf
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_senddtmf.c 242335 
> 
> Diff: https://reviewboard.asterisk.org/r/473/diff
> 
> 
> Testing
> -------
> 
> the all important make test ;-) also ran it through digits with all possible combination of options
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>




More information about the asterisk-dev mailing list