[asterisk-dev] [Code Review] Extend the max number of callgroups/pickupgroups

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/466/#review1380
-----------------------------------------------------------



trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/466/#comment3131>

    groupmatch will be true always



trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/466/#comment3132>

    groupmatch will be true always



trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/466/#comment3133>

    groupmatch will be true always



trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/466/#comment3134>

    I can't think of a better data structure to hold such a large number of flags...



trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment3135>

    I believe you can use the CHAR_BIT define instead.


- Jeff


On 2010-01-19 07:38:37, raarts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/466/
> -----------------------------------------------------------
> 
> (Updated 2010-01-19 07:38:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently the number of callgroups/pickupgroups is limited to 63, because the variable type that holds the group bits is a long long.
> 
> Here's a patch that extends this variable to an arbitrary-length (determined at compile time) int array. It currently sets the max number of groups to 1024.
> It implements this for all channels, but I only tested SIP and DAHDI.
> 
> Some people might object to implementing this as an array of ints, because it introduces a loop. But I think call pickups are not done often enough for this to become a problem.
> 
> See https://issues.asterisk.org/view.php?id=16640
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_dumpchan.c 241015 
>   trunk/channels/chan_agent.c 241015 
>   trunk/channels/chan_dahdi.c 241015 
>   trunk/channels/chan_gtalk.c 241015 
>   trunk/channels/chan_jingle.c 241015 
>   trunk/channels/chan_mgcp.c 241015 
>   trunk/channels/chan_misdn.c 241015 
>   trunk/channels/chan_sip.c 241015 
>   trunk/channels/chan_skinny.c 241015 
>   trunk/channels/chan_unistim.c 241015 
>   trunk/channels/misdn_config.c 241015 
>   trunk/doc/asterisk-mib.txt 241015 
>   trunk/funcs/func_channel.c 241015 
>   trunk/include/asterisk/channel.h 241015 
>   trunk/main/channel.c 241015 
>   trunk/main/cli.c 241015 
>   trunk/main/features.c 241015 
>   trunk/res/snmp/agent.c 241015 
> 
> Diff: https://reviewboard.asterisk.org/r/466/diff
> 
> 
> Testing
> -------
> 
> This patch has been in our asterisk 1.2 for 3 years now without problems. I ported it over to 1.6.2 and tested it there. The patch uploaded here is against trunk which is currently being tested by a colleague of mine, but they are all basically the same patch. 
> 
> 
> Thanks,
> 
> raarts
> 
>