[asterisk-dev] [Code Review] Add notification of interrupted file and fix bug

[thedavidfactor at gmail.com]

> On 2009-12-21 08:41:01, thedavidfactor wrote:
> > /trunk/apps/app_externalivr.c, line 684
> > <https://reviewboard.asterisk.org/r/449/diff/1/?file=7585#file7585line684>
> >
> >     are there any problems with doing an ast_strip like this?
> 
> Sean Bright wrote:
>     Since you aren't storing the return value, you will still have leading spaces when this returns (although trailing spaces will be 0 filled).
>

ok, I mainly wanted to make sure I wasn't doing something stupid that might cause a memory leak or something. Living with that constraint is not a problem. BTW, thanks for the feed back.


- thedavidfactor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/449/#review1337
-----------------------------------------------------------


On 2010-01-14 09:27:35, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/449/
> -----------------------------------------------------------
> 
> (Updated 2010-01-14 09:27:35)
> 
> 
> Review request for Asterisk Developers and Chris Tooley.
> 
> 
> Summary
> -------
> 
> There was some discussion with other users/developers and it seems that the most backwards compatible way to add notification for interrupted files would be to append the interrupted file information to the T event instead of generating an additional D event.
> 
> 
> This addresses bug 16147.
>     https://issues.asterisk.org/view.php?id=16147
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_externalivr.c 235516 
> 
> Diff: https://reviewboard.asterisk.org/r/449/diff
> 
> 
> Testing
> -------
> 
> in full time development use on-site
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>