[asterisk-dev] [Code Review] CDR: Add Calling and Called Subaddress fields to CDR record

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/460/
-----------------------------------------------------------

(Updated 2010-01-14 03:45:32.780457)


Review request for Asterisk Developers.


Changes
-------

added mantis bug reference, and mysql syntax to alter database to support new fields.


Summary (updated)
-------

Trunk now supports ISDN subaddress, as disussed on asterisk-dev list - better to add fields than to try manipulating existing fields.

Only records the received string, not the 'User Specified flag' or the Odd/Even flag.

I used the following syntax to add additional mysql fields
  mysql> alter table cdr ADD (callingsubaddr varchar(80) not null);
  mysql> alter table cdr ADD (calledsubaddr varchar(80) not null);
I need to check whether 'not null' is required, as in many cases the caller wont have subaddress info.

cdr backend collector support:
yes (after user adds required 'callingsubaddr' and 'calledsubaddr' fields):
   cdr_adaptive_odbc, cdr_mysql, cdr_pgsql and cdr_tds will automatically fill in field if like name field exists in database. 
   cdr_custom requires user added field in cdr_custom.conf like ;Master.csv => "${CDR(clid)}",${CDR(callingsubaddr)}", etc

maybe (requires cdr collector supporting code):
   cdr_custom, requires optional user config flag and supporting code, IE. cdr_csv:logcallingsubaddr=yes etc.
      Has been suggested to ignore cdr_custom, as users interested in 'dnid' wouldn't seriously be using cdr_custom.
   cdr_radius, requires optional user config flag and supporting code.
      Tilghman considered cdr_radius 'adaptive support', but it has no real method for querying what was supported on the backend.


This addresses bug 16600.
    https://issues.asterisk.org/view.php?id=16600


Diffs
-----

  trunk/main/cdr.c 239623 

Diff: https://reviewboard.asterisk.org/r/460/diff


Testing
-------


Thanks,

Alec