[asterisk-dev] [Code Review] Provide method for testing GotoIfTime without changing localtime

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/458/#review1360
-----------------------------------------------------------

Ship it!


Great work, this looks ready to go.  My only comment would be possibly finding a more descriptive name for ast_check_timing2.  This really doesn't matter and I'm not going to complain if you commit it the way it is.

- David


On 2010-01-12 17:48:47, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/458/
> -----------------------------------------------------------
> 
> (Updated 2010-01-12 17:48:47)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> During the recent holidays, we had discussions on the mailing list about being able to verify whether the dates and times chosen actually performed as expected.  To this end, I have created this method for setting the date and time at which GotoIfTime will be tested, to verify that a particular date and time will take a particular path.
> 
> 
> This addresses bug 16464.
>     https://issues.asterisk.org/view.php?id=16464
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/pbx.h 239307 
>   /trunk/main/pbx.c 239571 
> 
> Diff: https://reviewboard.asterisk.org/r/458/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tilghman
> 
>