[asterisk-dev] [Code Review] Provide method for testing GotoIfTime without changing localtime

[Tilghman Lesher]

> On 2010-01-12 16:18:24, David Vossel wrote:
> > /trunk/main/pbx.c, line 9015
> > <https://reviewboard.asterisk.org/r/458/diff/1/?file=7632#file7632line9015>
> >
> >     Ah, I understand.  Perhaps adding something like this would make it slightly more efficient then.
> >     
> >     if (ctime) {
> >         pbx_builtin_setvar_helper(chan, "TESTTIME", NULL);
> >     }
> >

A very excellent idea.  I actually wrapped a bit more, since it was clear that the WARNING was being generated in non-test cases, and I had intended it only on test cases.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/458/#review1356
-----------------------------------------------------------


On 2010-01-12 17:48:47, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/458/
> -----------------------------------------------------------
> 
> (Updated 2010-01-12 17:48:47)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> During the recent holidays, we had discussions on the mailing list about being able to verify whether the dates and times chosen actually performed as expected.  To this end, I have created this method for setting the date and time at which GotoIfTime will be tested, to verify that a particular date and time will take a particular path.
> 
> 
> This addresses bug 16464.
>     https://issues.asterisk.org/view.php?id=16464
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/pbx.h 239307 
>   /trunk/main/pbx.c 239571 
> 
> Diff: https://reviewboard.asterisk.org/r/458/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tilghman
> 
>