[asterisk-dev] [Code Review] Provide method for testing GotoIfTime without changing localtime

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/458/#review1355
-----------------------------------------------------------



/trunk/include/asterisk/pbx.h
<https://reviewboard.asterisk.org/r/458/#comment3095>

    While that's true, I prefer to provide backwards compatibility where possible.  In this case, it's nearly no extra effort to provide.



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/458/#comment3096>

    What this does is if the time doesn't validate, it saves us the time of attempting to evaluate the same thing in a subsequent step.  Typically, a holiday dialplan consists of many different GotoIfTime calls in sequence.  Once we spit out an error, complaining of syntax, it's useless to continue to spit out errors.  It does not serve the user to have duplicate errors.


- Tilghman


On 2010-01-11 15:22:43, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/458/
> -----------------------------------------------------------
> 
> (Updated 2010-01-11 15:22:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> During the recent holidays, we had discussions on the mailing list about being able to verify whether the dates and times chosen actually performed as expected.  To this end, I have created this method for setting the date and time at which GotoIfTime will be tested, to verify that a particular date and time will take a particular path.
> 
> 
> This addresses bug 16464.
>     https://issues.asterisk.org/view.php?id=16464
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/pbx.h 235421 
>   /trunk/main/pbx.c 235422 
> 
> Diff: https://reviewboard.asterisk.org/r/458/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tilghman
> 
>