[asterisk-dev] [Code Review] add silence gen to wait apps

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/456/#review1348
-----------------------------------------------------------


This really needs to exist as an option in my opinion since setting up a silence generator will require a translation path from signed linear to the codec in use. If G729 was being used then this would use a license. What happens if it can't get a path? What if the user wants to conserve licenses and does not care if no audio is sent in these scenarios?

- Joshua


On 2010-01-08 14:09:40, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/456/
> -----------------------------------------------------------
> 
> (Updated 2010-01-08 14:09:40)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> During the wait apps, Wait() WaitUntil() WaitForRing() WaitForSilence(), no audio is generated.  Since no audio is generated audiohooks arn't mixed with anything causing apps like ChanSpy to not work.  This patch adds silence generation to wait apps to create audio.
> 
> 
> This addresses bug 16524.
>     https://issues.asterisk.org/view.php?id=16524
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_waitforring.c 238629 
>   /trunk/apps/app_waitforsilence.c 238629 
>   /trunk/apps/app_waituntil.c 238629 
>   /trunk/main/pbx.c 238629 
> 
> Diff: https://reviewboard.asterisk.org/r/456/diff
> 
> 
> Testing
> -------
> 
> tested with ChanSpy, whisper now works with channels in Wait() app.
> 
> 
> Thanks,
> 
> David
> 
>