[asterisk-dev] [Code Review] Fix reading samples from format_mp3 after ast_seekstream/ast_tellstream
Sean Bright
sean.bright at gmail.com
Tue Jan 5 16:55:52 CST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/453/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
There is a bug when using ast_seekstream/ast_tellstream with format_mp3 in that the
file read position is not reset before attempting to read samples. So when we seek
to determine the maximum size of the file (as in res_agi's STREAM FILE) we weren't
then resetting the file pointer so that we could properly read samples. This patch
addresses that (in a similar manner to format_wav.c).
This addresses bug 15224.
https://issues.asterisk.org/view.php?id=15224
Diffs
-----
/trunk/addons/format_mp3.c 237919
Diff: https://reviewboard.asterisk.org/r/453/diff
Testing
-------
The reporter of issue 15224, rbd, tested and confirms that it resolves his problem.
Thanks,
Sean
More information about the asterisk-dev
mailing list