[asterisk-dev] [Code Review] New Media Architecture phase 1 step 1

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1062/#review3050
-----------------------------------------------------------


Great work so far David, just had a few comments. 


/trunk/include/asterisk/format.h
<https://reviewboard.asterisk.org/r/1062/#comment6268>

    The enum values should be renamed to something that makes more sense.
    
    AST_FORMAT_CMP_SAME should be AST_FORMAT_CMP_EQUAL.
    
    NOT_SUBSET should probably be NOT_EQUAL
    



/trunk/main/format.c
<https://reviewboard.asterisk.org/r/1062/#comment6269>

    Using the ao2 lock for this wrapper object is not going to work.  The interface must be accessed to often to use this sort of locking.  A rw lock makes more sense here even though this structure will need to remain an ao2 object to work with the ao2_container.


- David


On 2010-12-17 15:51:34, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1062/
> -----------------------------------------------------------
> 
> (Updated 2010-12-17 15:51:34)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Here is what I am working on. https://wiki.asterisk.org/wiki/display/AST/Media+Architecture+Proposal
> 
> This is phase 1 step 1 of that proposal.
> 
> Below is everything that is included in this review.
> 
> Step 1
>     * Define new format unique ID system using numbers rather than bits. Allow this definition to remain unused during this step except by the new APIs.
>     * Create Ast Format API + unit tests.
>     * Create Ast Capibility API + unit tests.
>     * Create IAX2 Conversion layer for ast_format and ast_cap objects. Create unit tests and leave this layer inactive until conversion to new APIs takes place.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/format.h PRE-CREATION 
>   /trunk/include/asterisk/format_cap.h PRE-CREATION 
>   /trunk/main/format.c PRE-CREATION 
>   /trunk/main/format_cap.c PRE-CREATION 
>   /trunk/tests/test_format_api.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1062/diff
> 
> 
> Testing
> -------
> 
> Unit tests are included.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101219/4f41e855/attachment.htm>