[asterisk-dev] [Code Review] Parse mwi => lines in sip.conf properly to avoid segfaults and have it work.

[Marquis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1053/
-----------------------------------------------------------

(Updated 2010-12-15 17:17:49.366207)


Review request for Asterisk Developers.


Changes
-------

Fixed crash bug as pointed out by David Vossel and added unit tests suggested by both he and Russell Bryant.


Summary
-------

Modify the parsing of mwi subscription lines in sip.conf in order to avoid an existing segfault and to have it properly populate the struct for subscriptions.


This addresses bug 18350.
    https://issues.asterisk.org/view.php?id=18350


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 298391 
  /branches/1.8/configs/sip.conf.sample 298391 

Diff: https://reviewboard.asterisk.org/r/1053/diff


Testing
-------

Added lines for various possible permutations (kept in the diff for documentation) as well as temporary (not in the diff) debug lines to verify all strings were set to their expected values.  Reporter in issue 18350 also applied patch and verified that his segfault was gone and that subscriptions were working.


Thanks,

Marquis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101215/a1701b95/attachment-0001.htm>