[asterisk-dev] [Code Review] fix mixmonitor test and create 'soundcard' dependency

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1057/#review3030
-----------------------------------------------------------

Ship it!


- Russell


On 2010-12-14 11:23:45, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1057/
> -----------------------------------------------------------
> 
> (Updated 2010-12-14 11:23:45)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> After trying to debug tests/mixmonitor failures under FreeBSD, it finally occurred to me the system didn't have a sound card.  It seems under Linux, Asterisk will still create audio files (they are empty), but under FreeBSD the file does not get created.  So, we can assume chan_oss.so requires a sound card, and if none is present on the system, we can skip all tests that require it.
> 
> For now, we check if we can open dev/dsp.
> 
> Additionally, added logic to mixmonitor/run-test and now it successfully passes.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/runtests.py 1161 
>   asterisk/trunk/tests/cdr/cdr_unanswered_yes/test-config.yaml 1161 
>   asterisk/trunk/tests/cdr/cdr_userfield/test-config.yaml 1161 
>   asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml 1161 
>   asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml 1161 
>   asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml 1161 
>   asterisk/trunk/tests/cdr/console_dial_sip_transfer/test-config.yaml 1161 
>   asterisk/trunk/tests/cdr/console_fork_after_busy_forward/test-config.yaml 1161 
>   asterisk/trunk/tests/cdr/console_fork_before_dial/test-config.yaml 1161 
>   asterisk/trunk/tests/cdr/nocdr/test-config.yaml 1161 
>   asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/test-config.yaml 1161 
>   asterisk/trunk/tests/directed_pickup/test-config.yaml 1161 
>   asterisk/trunk/tests/mixmonitor/configs/ast1/extensions.conf 1161 
>   asterisk/trunk/tests/mixmonitor/configs/ast1/manager.conf PRE-CREATION 
>   asterisk/trunk/tests/mixmonitor/run-test 1161 
>   asterisk/trunk/tests/mixmonitor/test-config.yaml 1161 
>   asterisk/trunk/tests/mixmonitor_audiohook_inherit/test-config.yaml 1161 
> 
> Diff: https://reviewboard.asterisk.org/r/1057/diff
> 
> 
> Testing
> -------
> 
> Local, and FreeBSD box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101215/550de116/attachment.htm>