[asterisk-dev] [Code Review] optimize fastagi tests.

[Paul Belanger]

> On 2010-12-03 15:36:46, Tilghman Lesher wrote:
> > asterisk/trunk/tests/fastagi/say-alpha/run-test, lines 85-93
> > <https://reviewboard.asterisk.org/r/1045/diff/4/?file=14314#file14314line85>
> >
> >     This patch seems to remove a lot of debugging commands that might be otherwise helpful when the test breaks.  Might we want to keep those?  Do they slow down the test in any appreciable way?

I've removed them for the moment, but plan to add them back with my next patch.  I'd like to next standardize the debugging messages tests use, Russell pointed out a logging class the other day, I'm interested in adding that to our testsuite, so all tests write debug message to a standard location.

I found out the hard way it is not difficult to break bamboo's ability to parse the result XML file.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1045/#review3002
-----------------------------------------------------------


On 2010-12-03 15:01:27, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1045/
> -----------------------------------------------------------
> 
> (Updated 2010-12-03 15:01:27)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I've reworked the fastagi tests, increasing performance on FreeBSD from 22mins to 2mins.   Most of the issues revolved around static timeouts within the tests, I've removed them in favor of dynamic timeouts.  I've also move starting / stopping outside the scope of the tests as the test should NOT depend on Asterisk starting or stopping. 
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/fastagi/channel-status/run-test 1055 
>   asterisk/trunk/tests/fastagi/configs/ast1/extensions.conf 1055 
>   asterisk/trunk/tests/fastagi/connect/run-test 1055 
>   asterisk/trunk/tests/fastagi/control-stream-file/run-test 1055 
>   asterisk/trunk/tests/fastagi/database/run-test 1055 
>   asterisk/trunk/tests/fastagi/execute/run-test 1055 
>   asterisk/trunk/tests/fastagi/get-data/run-test 1055 
>   asterisk/trunk/tests/fastagi/hangup/run-test 1055 
>   asterisk/trunk/tests/fastagi/record-file/run-test 1055 
>   asterisk/trunk/tests/fastagi/say-alpha/run-test 1055 
>   asterisk/trunk/tests/fastagi/say-date/run-test 1055 
>   asterisk/trunk/tests/fastagi/say-datetime/run-test 1055 
>   asterisk/trunk/tests/fastagi/say-digits/run-test 1055 
>   asterisk/trunk/tests/fastagi/say-number/run-test 1055 
>   asterisk/trunk/tests/fastagi/say-phonetic/run-test 1055 
>   asterisk/trunk/tests/fastagi/say-time/run-test 1055 
>   asterisk/trunk/tests/fastagi/stream-file/run-test 1055 
>   asterisk/trunk/tests/fastagi/tests.yaml 1055 
>   asterisk/trunk/tests/fastagi/wait-for-digit/run-test 1055 
> 
> Diff: https://reviewboard.asterisk.org/r/1045/diff
> 
> 
> Testing
> -------
> 
> Local box, and slow FreeBSD system.  Both passed.
> 
> Asterisk 1.4 and trunk.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101203/b4bd11b1/attachment-0001.htm