[asterisk-dev] [Code Review] AST-33: Create a list of channel variables to be posted within AMI call events

Tilghman Lesher tlesher at digium.com
Thu Sep 17 15:47:01 CDT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/368/
-----------------------------------------------------------

(Updated 2009-09-17 15:47:01.388986)


Review request for Asterisk Developers.


Changes
-------

Tested functionality, added dialplan functions (CDR(accountcode) and other CDR() variables are the likely use)


Summary
-------

The intent of this patch is to post various variables from a related channel, when posting certain call-related events to the manager interface.

For example, the following manager.conf entry:

channelvars=SV_OWNER,SV_PEER,DISPLAY_URL

will result in the following manager output for a Newstate event:

Event: Newstate
Privilege: call,all
Channel: SIP/200-08b75888
State: Up
CallerID: 200
CallerIDName: Snom Phone
Uniqueid: 1209084781.0
Channel1Var-SV_OWNER: a1101
Channel1Var-SV_PEER: a1116
Channel1Var-DISPLAY_URL:

For Link events, you'll also see Channel2Var-type entries for the
corresponding bridged channel.


Diffs (updated)
-----

  /trunk/apps/app_chanspy.c 219231 
  /trunk/apps/app_dial.c 219231 
  /trunk/apps/app_fax.c 219231 
  /trunk/apps/app_meetme.c 219231 
  /trunk/apps/app_minivm.c 219231 
  /trunk/apps/app_queue.c 219231 
  /trunk/apps/app_voicemail.c 219231 
  /trunk/channels/chan_iax2.c 219231 
  /trunk/channels/chan_sip.c 219231 
  /trunk/configs/manager.conf.sample 219231 
  /trunk/include/asterisk/manager.h 219231 
  /trunk/main/cdr.c 219231 
  /trunk/main/channel.c 219231 
  /trunk/main/features.c 219231 
  /trunk/main/manager.c 219231 
  /trunk/res/res_monitor.c 219231 
  /trunk/res/res_musiconhold.c 219231 

Diff: https://reviewboard.asterisk.org/r/368/diff


Testing
-------

It compiles!  Ship it!


Thanks,

Tilghman




More information about the asterisk-dev mailing list