[asterisk-dev] [Code Review] SIP: peer matching by address with TCP/TLS

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/354/
-----------------------------------------------------------

(Updated 2009-09-04 14:06:09.933394)


Review request for Asterisk Developers.


Changes
-------

Now peers_by_ip is hashed only by ip. not ip and port


Summary
-------

Using both the ip address and port number to peer match a connection coming in over tcp does not work.  A work around for this issue was committed a few months ago which used the contact header to peer match tcp connections. This is incorrect.  Instead, peer matching for tcp connections should be done by ip address only.

This patch removes the contact header matching logic and adds logic to match all tcp/tls connections by ip only.


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 216506 

Diff: https://reviewboard.asterisk.org/r/354/diff


Testing
-------

tested invites over tcp, verified peer matching by ip works correctly.


Thanks,

David