[asterisk-dev] [Code Review] Optionally build apps in utils/ directory
Michiel van Baak
michiel at vanbaak.info
Fri Sep 4 13:54:25 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/353/#review1057
-----------------------------------------------------------
Ship it!
Like you said, remove the astcanary from menuselect and build it by default.
Besides that, looks good.
- Michiel
On 2009-09-04 11:09:11, Sean Bright wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/353/
> -----------------------------------------------------------
>
> (Updated 2009-09-04 11:09:11)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Based on a recent janitor submitted by oej, make the build of utilities optional
> based on selections made within menuselect. The only change I could see being
> necessary before this gets committed is removing astcanary from the list of
> optional utilities and just building it every time.
>
>
> Diffs
> -----
>
> /trunk/Makefile 216509
> /trunk/utils/Makefile 216509
> /trunk/utils/utils.xml PRE-CREATION
>
> Diff: https://reviewboard.asterisk.org/r/353/diff
>
>
> Testing
> -------
>
> Fired up menuselect, chose different utils to build, and built.
>
>
> Thanks,
>
> Sean
>
>
More information about the asterisk-dev
mailing list