[asterisk-dev] [Code Review] Dynamic parking lots

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/352/#review1053
-----------------------------------------------------------

Ship it!


Other than a few minor comments, this looks good to me.


/trunk/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/352/#comment2581>

    It looks like the other comments in this file are spaced over using spaces and not tabs.  Might want to be consistent.  (This might just be showing up strange in reviewboard, however)



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2580>

    This text could use some re-working.  Some of it doesn't make sense and it's missing some punctuation.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2578>

    dynamicaly -> dynamically



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2579>

    You should probably give the second argument a name for consistency.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2582>

    Add spaces before the "" in these lines.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2583>

    Space before the "".


- Sean


On 2009-09-02 15:59:58, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/352/
> -----------------------------------------------------------
> 
> (Updated 2009-09-02 15:59:58)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This pathc intended to introduce fully dynamic parking. As requested in bounty variables PARKINGEXTEN and PARKINGLOT can be defined anywhere in dialplan or AGI and parking lot not defined in features.conf. On call park new parking lot 'll be created based on default lot settings or settings of parkinglot from PARKINGDYNAMIC variable.
> 
> Also variables PARKINGDYNCONTEXT and PARKINGDYNPOS introduce to control parking context and positions of newly created parking lot.
> 
> New behavior controlled by setting 'parkeddynamic' in features.conf 
> 
> 
> This addresses bug 15135.
>     https://issues.asterisk.org/view.php?id=15135
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/features.conf.sample 215647 
>   /trunk/main/features.c 215647 
> 
> Diff: https://reviewboard.asterisk.org/r/352/diff
> 
> 
> Testing
> -------
> 
> Added the variables in dialplan, setup call, parked, and verified it ended up in the parkinglot. parkinglot was not added to features.conf. Also retrieved the call again.
> 
> IgorG and acunningham reported success as well
> 
> 
> Thanks,
> 
> Michiel
> 
>