[asterisk-dev] [Code Review] Dynamic parking lots

[Michiel van Baak]

> On 2009-09-02 12:37:48, Sean Bright wrote:
> > /trunk/main/features.c, line 666
> > <https://reviewboard.asterisk.org/r/352/diff/1/?file=6332#file6332line666>
> >
> >     Space after if

done


> On 2009-09-02 12:37:48, Sean Bright wrote:
> > /trunk/main/features.c, line 673
> > <https://reviewboard.asterisk.org/r/352/diff/1/?file=6332#file6332line673>
> >
> >     This should have the same scanf() changes as Tilghman committed a few months ago (i.e. %30d instead of %d)

done


> On 2009-09-02 12:37:48, Sean Bright wrote:
> > /trunk/main/features.c, lines 700-702
> > <https://reviewboard.asterisk.org/r/352/diff/1/?file=6332#file6332line700>
> >
> >     This looks like a bug-fix.  Should probably go in as a separate commit.

agreed.


> On 2009-09-02 12:37:48, Sean Bright wrote:
> > /trunk/main/features.c, lines 3504-3505
> > <https://reviewboard.asterisk.org/r/352/diff/1/?file=6332#file6332line3504>
> >
> >     I'm not sure if this is needed, but shouldn't the linked list of parked calls (parkings member of ast_parkinglog) be reset/initialized as well?

no, park_space_reserve will do this.
And since that is the only place we call copy_parkinglot I do not think we have to.


- Michiel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/352/#review1048
-----------------------------------------------------------


On 2009-09-02 11:53:42, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/352/
> -----------------------------------------------------------
> 
> (Updated 2009-09-02 11:53:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This pathc intended to introduce fully dynamic parking. As requested in bounty variables PARKINGEXTEN and PARKINGLOT can be defined anywhere in dialplan or AGI and parking lot not defined in features.conf. On call park new parking lot 'll be created based on default lot settings or settings of parkinglot from PARKINGDYNAMIC variable.
> 
> Also variables PARKINGDYNCONTEXT and PARKINGDYNPOS introduce to control parking context and positions of newly created parking lot.
> 
> New behavior controlled by setting 'parkeddynamic' in features.conf 
> 
> 
> This addresses bug 15135.
>     https://issues.asterisk.org/view.php?id=15135
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/features.conf.sample 215512 
>   /trunk/main/features.c 215512 
> 
> Diff: https://reviewboard.asterisk.org/r/352/diff
> 
> 
> Testing
> -------
> 
> Added the variables in dialplan, setup call, parked, and verified it ended up in the parkinglot. parkinglot was not added to features.conf. Also retrieved the call again.
> 
> IgorG and acunningham reported success as well
> 
> 
> Thanks,
> 
> Michiel
> 
>