[asterisk-dev] [Code Review] SIP uri parsing cleanup

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/343/#review1046
-----------------------------------------------------------

Ship it!


Other than this one minor suggestion, this looks good to me.

Very nice work, David!


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/343/#comment2563>

    Should we use sscanf() here to check for conversion errors?


- Russell


On 2009-09-02 09:36:45, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/343/
> -----------------------------------------------------------
> 
> (Updated 2009-09-02 09:36:45)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Originally anytime parse_uri() was used it first had to be passed the "sip" scheme, then if that failed it had to be passed the "sips" scheme.  This required two identical uri buffers. Now parse_uri can just be called once with a single buffer.  This patch also addresses an issue where the "transport=" field of a uri was not being handled correctly.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 215151 
> 
> Diff: https://reviewboard.asterisk.org/r/343/diff
> 
> 
> Testing
> -------
> 
> compiles, registers, makes calls..
> 
> 
> Thanks,
> 
> David
> 
>