[asterisk-dev] [Code Review] SIP uri parsing cleanup

[Nick Lewis]

I think this is a good and flexible solution
"sip,sips,tel" could be used if enum support were needed

-----Original Message-----
From: asterisk-dev-bounces at lists.digium.com
[mailto:asterisk-dev-bounces at lists.digium.com] On Behalf Of David Vossel
Sent: 01 September 2009 23:02
To: David Vossel; Asterisk Developers
Subject: Re: [asterisk-dev] [Code Review] SIP uri parsing cleanup


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/343/
-----------------------------------------------------------

(Updated 2009-09-01 17:02:14.930814)


Review request for Asterisk Developers.


Changes
-------

This gets rid of the whole parse_uri and parse_uri_helper stuff.  Now,
the scheme passed to parse_uri can either be a single scheme, or a list
of schemes ',' delimited.  This gets rid of the whole problem of having
to create two buffers and calling parse_uri twice to check for separate
schemes.


Summary
-------

Originally anytime parse_uri() was used it first had to be passed the
"sip" scheme, then if that failed it had to be passed the "sips" scheme.
This required two identical uri buffers and was quite ridiculous. Now
parse_uri can just be called once with a single buffer.  This patch also
addresses an issue where the "transport=" field of a uri was not being
handled correctly.

I was about to copy the old trend again with some new code I am writing,
but I just could not stand it any longer.


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 215151 

Diff: https://reviewboard.asterisk.org/r/343/diff


Testing
-------

compiles, registers, makes calls..


Thanks,

David


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

AstriCon 2009 - October 13 - 15 Phoenix, Arizona
Register Now: http://www.astricon.net

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

______________________________________________________________________
This e-mail has been scanned for all viruses by Star. The
service is powered by MessageLabs. For more information on a proactive
anti-virus service working around the clock, around the globe, visit:
http://www.star.net.uk
______________________________________________________________________

_____________________________________________________________________
This message has been checked for all known viruses by Star Internet delivered through the MessageLabs Virus Control Centre.
_____________________________________________________________________
Disclaimer of Liability
ATL Telecom Ltd shall not be held liable for any improper or incorrect use of the  information described and/or contained herein and assumes no responsibility for anyones use  of the information. In no event shall ATL Telecom Ltd be liable for any direct, indirect,  incidental, special, exemplary, or consequential damages (including, but not limited to,  procurement or substitute goods or services; loss of use, data, or profits; or business  interruption) however caused and on any theory of liability, whether in contract, strict  liability, or tort (including negligence or otherwise) arising in any way out of the use of  this system, even if advised of the possibility of such damage.

Registered Office: ATL Telecom Ltd, Fountain Lane, St. Mellons Cardiff, CF3 0FB
Registered in Wales Number 4335781

All goods and services supplied by ATL Telecom Ltd are supplied subject to ATL Telecom Ltd standard terms and conditions, available upon request.