[asterisk-dev] [Code Review] SIP uri parsing cleanup

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/343/
-----------------------------------------------------------

(Updated 2009-09-01 17:02:14.930814)


Review request for Asterisk Developers.


Changes
-------

This gets rid of the whole parse_uri and parse_uri_helper stuff.  Now, the scheme passed to parse_uri can either be a single scheme, or a list of schemes ',' delimited.  This gets rid of the whole problem of having to create two buffers and calling parse_uri twice to check for separate schemes.


Summary
-------

Originally anytime parse_uri() was used it first had to be passed the "sip" scheme, then if that failed it had to be passed the "sips" scheme.  This required two identical uri buffers and was quite ridiculous. Now parse_uri can just be called once with a single buffer.  This patch also addresses an issue where the "transport=" field of a uri was not being handled correctly.

I was about to copy the old trend again with some new code I am writing, but I just could not stand it any longer.


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 215151 

Diff: https://reviewboard.asterisk.org/r/343/diff


Testing
-------

compiles, registers, makes calls..


Thanks,

David