[asterisk-dev] [Code Review] Add mutestream manager action and MUTESTREAM() dialplan function

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/345/#review1041
-----------------------------------------------------------

Ship it!


Beyond these last very minor suggestions, this looks good to go!


./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2548>

    I suppose you could add "\ingroup functions" here.



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2549>

    These are probably not needed.



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2550>

    space after if



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2551>

    little bit of trailing whitespace



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2552>

    space after if



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2553>

    I would declare this as "static const char"  (add const)



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2554>

    whitespace


- Russell


On 2009-09-01 13:31:07, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/345/
> -----------------------------------------------------------
> 
> (Updated 2009-09-01 13:31:07)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When you need to be able to mute incoming or outgoing audio for a channel, this is the function you need.
> 
> I am a bit unsure of the unload functionality. What will happen if I unload an audiohook module when a channel is active? 
> 
> This work is inspired by app_jack.c and func_volume.c
> 
> 
> Diffs
> -----
> 
>   ./res/res_mutestream.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/345/diff
> 
> 
> Testing
> -------
> 
> I've tested this in manager and with the dynamic features in features.conf.
> 
> 
> Thanks,
> 
> Olle E
> 
>