[asterisk-dev] [Code Review] SIP: peer matching bycallbackextension

[Nick Lewis]

oej

>I think we have to solve this differently. When we register, we don't  
>register the extension as a contact, we generate a unique random  
>string. When the call comes back, the random string will be the  
>request URI and we can match on that. I actually have code for that  
>somewhere.

I do not see the advantage of a unique random string. I suggest a
different unique string - the peername.

>What messes that up is that you know frequently have registrations for

>SIP trunks where you won't get the contact back in the request URI,  
>which messes things up.

I have also experienced some trunk providers that make this mistake.
They tend to send the username back instead. In these cases I simply
name the peer after the username. This does not clash with other
peernames on the system because client peers have shorter names e.g.
[101] and trunk peers typically have usernames that are PSTN numbers
e.g. [442920500718] and hence unique.

>I suggest we keep this code, but put it on hold until we have decided  
>what to do. Yet another hack in the already messy device matching  
>algorithm doesn't help and the callbackextension hack is ugly enough  
>as it is.

I agree that the "callbackextension=" and "register=.../extension~..."
hack is ugly (I do not use it in my implementations) but as asterisk
currently contains this unusual concept, I think it needs to be
self-consistent and to work. Hence the patch.

Nick_Lewis

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

AstriCon 2009 - October 13 - 15 Phoenix, Arizona
Register Now: http://www.astricon.net

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

______________________________________________________________________
This e-mail has been scanned for all viruses by Star. The
service is powered by MessageLabs. For more information on a proactive
anti-virus service working around the clock, around the globe, visit:
http://www.star.net.uk
______________________________________________________________________

_____________________________________________________________________
This message has been checked for all known viruses by Star Internet delivered through the MessageLabs Virus Control Centre.
_____________________________________________________________________
Disclaimer of Liability
ATL Telecom Ltd shall not be held liable for any improper or incorrect use of the  information described and/or contained herein and assumes no responsibility for anyones use  of the information. In no event shall ATL Telecom Ltd be liable for any direct, indirect,  incidental, special, exemplary, or consequential damages (including, but not limited to,  procurement or substitute goods or services; loss of use, data, or profits; or business  interruption) however caused and on any theory of liability, whether in contract, strict  liability, or tort (including negligence or otherwise) arising in any way out of the use of  this system, even if advised of the possibility of such damage.

Registered Office: ATL Telecom Ltd, Fountain Lane, St. Mellons Cardiff, CF3 0FB
Registered in Wales Number 4335781

All goods and services supplied by ATL Telecom Ltd are supplied subject to ATL Telecom Ltd standard terms and conditions, available upon request.