[asterisk-dev] [Code Review] SIP uri parsing cleanup

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/343/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Originally anytime parse_uri() was used it first had to be passed the "sip" scheme, then if that failed it had to be passed the "sips" scheme.  This required two identical uri buffers and was quite ridiculous. Now parse_uri can just be called once with a single buffer.  This patch also addresses an issue where the "transport=" field of a uri was not being handled correctly.

I was about to copy the old trend again with some new code I am writing, but I just could not stand it any longer.


Diffs
-----

  /trunk/channels/chan_sip.c 214269 

Diff: https://reviewboard.asterisk.org/r/343/diff


Testing
-------

compiles, registers, makes calls..


Thanks,

David