[asterisk-dev] [Code Review] CLI filtering [GSoC 2009]

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/336/#review1007
-----------------------------------------------------------



/trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/336/#comment2375>

    In every channel driver where you have done an add, you need to do a remove(), after you start the PBX on the channel.



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/336/#comment2376>

    To prevent this from crashing, you need to take a reference on the channel:
    
    filter->chan = ast_channel_ref(chan);
    
    Then, in your thread cleanup function, you should unref the channel:
    
    ast_channel_unref(chan);
    
    Otherwise, it is very likely that you will end up accessing fields in the channel after it has been freed.


- Russell


On 2009-08-06 22:01:42, junky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/336/
> -----------------------------------------------------------
> 
> (Updated 2009-08-06 22:01:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> CLI filtering for the gsoc 2009
> 
> This is the first patch to add functionality to filter CLI.
> 
> 
> See usages and examples in doc/cli_filters.txt
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 210860 
>   /trunk/channels/chan_alsa.c 210860 
>   /trunk/channels/chan_bridge.c 210860 
>   /trunk/channels/chan_dahdi.c 210860 
>   /trunk/channels/chan_gtalk.c 210860 
>   /trunk/channels/chan_h323.c 210860 
>   /trunk/channels/chan_iax2.c 210860 
>   /trunk/channels/chan_jingle.c 210860 
>   /trunk/channels/chan_local.c 210860 
>   /trunk/channels/chan_mgcp.c 210860 
>   /trunk/channels/chan_misdn.c 210860 
>   /trunk/channels/chan_multicast_rtp.c 210860 
>   /trunk/channels/chan_nbs.c 210860 
>   /trunk/channels/chan_oss.c 210860 
>   /trunk/channels/chan_phone.c 210860 
>   /trunk/channels/chan_skinny.c 210860 
>   /trunk/channels/chan_unistim.c 210860 
>   /trunk/channels/chan_usbradio.c 210860 
>   /trunk/channels/chan_vpb.cc 210860 
>   /trunk/include/asterisk/logger.h 210860 
>   /trunk/include/asterisk/pbx.h 210860 
>   /trunk/include/asterisk/threadstorage.h 210860 
>   /trunk/main/logger.c 210860 
>   /trunk/main/manager.c 210860 
>   /trunk/main/pbx.c 210860 
>   /trunk/main/threadstorage.c 210860 
> 
> Diff: https://reviewboard.asterisk.org/r/336/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> junky
> 
>