[asterisk-dev] [Code Review] SIP option to specify outbound TLS/SSL client protocol.

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/240/#review757
-----------------------------------------------------------

Ship it!


Very good addition. Thanks! 

- Olle E


On 2009-04-29 14:24:20, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/240/
> -----------------------------------------------------------
> 
> (Updated 2009-04-29 14:24:20)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_sip allows for outbound TLS connections, but does not allow the user to specify what protocol to use.  This patch lets the user pick the SSL/TLS client method for outbound connections in sip. 
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/tcptls.h 191028 
>   /trunk/main/tcptls.c 191028 
>   /trunk/CHANGES 191028 
>   /trunk/configs/sip.conf.sample 191027 
> 
> Diff: http://reviewboard.digium.com/r/240/diff
> 
> 
> Testing
> -------
> 
> tried TLSv1, SSLv2, SSLv3, all seemed to work correctly when tested back to back with Asterisk.  additional testing using ssldump has been done to verify the correct protocol is being sent. 
> 
> 
> Thanks,
> 
> David
> 
>