[asterisk-dev] [Code Review] SIP option to specify outbound TLS/SSL client protocol.

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/240/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

chan_sip allows for outbound TLS connections, but does not allow the user to specify what protocol to use.  This patch lets the user pick the SSL/TLS client method for outbound connections in sip. 


Diffs
-----

  /trunk/include/asterisk/tcptls.h 191028 
  /trunk/main/tcptls.c 191028 
  /trunk/CHANGES 191028 
  /trunk/configs/sip.conf.sample 191027 

Diff: http://reviewboard.digium.com/r/240/diff


Testing
-------

tried TLSv1, SSLv2, SSLv3, all seemed to work correctly when tested back to back with Asterisk.  additional testing using wireshark will be conducted to verify correct SSL/TLS headers are used.  Having issues at the moment getting wireshark to dissect SSL and TLS.


Thanks,

David