[asterisk-dev] [Code Review] Consistent SSL/TLS options across conf files

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/237/#review755
-----------------------------------------------------------

Ship it!


I like this change. Note that SSL and TLS are not the same protocol. I think we have to document somewhere that even though the options are named "tls*" the also apply to SSL communication. Hopefully, very few devices out there does not support TLS, but nevertheless...

- Olle E


On 2009-04-28 14:49:50, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/237/
> -----------------------------------------------------------
> 
> (Updated 2009-04-28 14:49:50)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> ast_tls_read_conf() is a new api call for handling SSL/TLS options across all conf files.  Before this change, SSL/TLS options were not consistent.  http.conf and manager.conf required the 'ssl' prefix while sip.conf used options with the 'tls' prefix.  While the options had different names in different conf files, they all did the exact same thing.  Now, instead of mixing 'ssl' or 'tls' prefixes to do the same thing depending on what conf file you're in, all SSL/TLS options use the 'tls' prefix.
> 
> For example.  'sslenable' in http.conf and manager.conf is now 'tlsenable' which matches what already existed in sip.conf. 
> 
> Since this has the potential to break backwards compatibility, previous options containing the 'ssl' prefix still work, but they are no longer documented in the sample.conf files.  The change is noted in the CHANGES file though.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 190940 
>   /trunk/channels/chan_sip.c 190940 
>   /trunk/configs/http.conf.sample 190940 
>   /trunk/configs/manager.conf.sample 190940 
>   /trunk/include/asterisk/tcptls.h 190940 
>   /trunk/main/http.c 190940 
>   /trunk/main/manager.c 190940 
>   /trunk/main/tcptls.c 190940 
> 
> Diff: http://reviewboard.digium.com/r/237/diff
> 
> 
> Testing
> -------
> 
> tested tls with old 'ssl' prefix options in manager.conf, still works, tested with new 'tls' prefix in manager.conf and sip.conf.  worked as expected.  
> 
> 
> Thanks,
> 
> David
> 
>