[asterisk-dev] [Code Review] HTTP Digest authentication

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/223/#review743
-----------------------------------------------------------

Ship it!


Aside from this MAX_SESSIONS thing, if it has been tested to be working, I say go for it.


/trunk/main/manager.c
<http://reviewboard.digium.com/r/223/#comment1887>

    This looks like a limitation that was not there previously.  I also can't tell why it was added.  I say we remove it.


- Russell


On 2009-04-17 18:16:57, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/223/
> -----------------------------------------------------------
> 
> (Updated 2009-04-17 18:16:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Enable the use of HTTP Digest authentication when using the AMI HTTP interface.
> 
> 
> This addresses bug 10961.
>     http://bugs.digium.com/view.php?id=10961
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/http.h 189200 
>   /trunk/include/asterisk/utils.h 189200 
>   /trunk/main/astobj2.c 189200 
>   /trunk/main/http.c 189200 
>   /trunk/main/manager.c 189200 
>   /trunk/main/utils.c 189200 
>   /trunk/res/res_http_post.c 189200 
>   /trunk/res/res_phoneprov.c 189200 
> 
> Diff: http://reviewboard.digium.com/r/223/diff
> 
> 
> Testing
> -------
> 
> Lots of testing with fairly large files; all issues found were resolved.
> 
> 
> Thanks,
> 
> Tilghman
> 
>