[asterisk-dev] [Code Review] Make the parameter separator backward compatible, and error messages more consistent.

[Eliel Sardañons]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/79/
-----------------------------------------------------------

(Updated 2009-04-23 11:27:34.813758)


Review request for Asterisk Developers.


Changes
-------

Address Mark's comments searching for pbx_findapp, pbx_exec, etc to replace other places where a ',' was used instead of AST_STANDARD_APP_DELIM.

There is a place in app_mixmonitor that couldn't figure out what was trying to replace (also the code was duplicated), maybe that is another place to use ast_standard_app_delim.


Summary
-------

This patch implements an asterisk.conf [compat] option called app_delim, to make applications and functions parameter delimiter backward compatible. if app_delim < 1.5 then, then app/fun delimited should be | (pipe), otherwise it should be "," comma.
Also there are a number of functions that where not using STANDARD_APP_ARG to parse the app/fun parameters, so, that was changed to use AST_STANDARD_APP_DELIM.
When printing error messages, we where printing the "syntax" with a hardcoded parameter separator, now the syntax being printed is the one generated with the xml documentation, so the error messages will be consistent with the actual parameter separator, and also with the actual app/fun syntax.


Diffs (updated)
-----

  /trunk/apps/app_dial.c 190216 
  /trunk/apps/app_exec.c 190216 
  /trunk/apps/app_macro.c 190216 
  /trunk/apps/app_meetme.c 190216 
  /trunk/apps/app_page.c 190216 
  /trunk/apps/app_queue.c 190216 
  /trunk/apps/app_readfile.c 190216 
  /trunk/apps/app_stack.c 190216 
  /trunk/apps/app_voicemail.c 190216 
  /trunk/funcs/func_callerid.c 190216 
  /trunk/funcs/func_cut.c 190216 
  /trunk/funcs/func_env.c 190216 
  /trunk/funcs/func_realtime.c 190216 
  /trunk/funcs/func_strings.c 190216 
  /trunk/include/asterisk/app.h 190216 
  /trunk/include/asterisk/pbx.h 190216 
  /trunk/main/features.c 190216 
  /trunk/main/pbx.c 190216 
  /trunk/main/xmldoc.c 190216 
  /trunk/pbx/pbx_lua.c 190216 
  /trunk/res/res_agi.c 190216 

Diff: http://reviewboard.digium.com/r/79/diff


Testing
-------

Developer testing.


Thanks,

Eliel