[asterisk-dev] [Code Review] Segfault when switching upd to tcp in sip.conf after reload

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/229/
-----------------------------------------------------------

(Updated 2009-04-21 12:36:36.915979)


Review request for Asterisk Developers.


Summary (updated)
-------

If transport in sip.conf is switched from upd to tcp, Asterisk segfaults right after issuing a sip reload.  The problem is the socket type is changed to TCP but the fd may still be present for UDP.  Later, when the tcp session should be created or set using an existing one, it isn't because the old file descriptor is still present.  Now every time transport is changed during a sip.conf reload, the file descriptor is set to -1, signifying it must be created or found.


This addresses bug 14727.
    http://bugs.digium.com/view.php?id=14727


Diffs
-----

  /trunk/channels/chan_sip.c 189663 

Diff: http://reviewboard.digium.com/r/229/diff


Testing
-------

switched between tcp and udp, upd to tcp, did reloads, no problems. 


Thanks,

David