[asterisk-dev] [Code Review] Integrate DAHDIScan into chanspy

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/227/#review721
-----------------------------------------------------------

Ship it!


Nice work, David!

- Russell


On 2009-04-20 14:41:19, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/227/
> -----------------------------------------------------------
> 
> (Updated 2009-04-20 14:41:19)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> DAHDIScan is holding up the astobj2 branch.  This patch moves DAHDIScan into app_chanspy to use chanspy's common_exec logic.
> 
> The original plan was to call chanspy within DAHDIScan.  In order not to break DAHDIScan's expected behavior, this requires two new features to be added into chanspy.  One for setting custom DTMF for cycling the next available channel, and another for setting custom DTMF for exiting.  As it turns out, this was not enough to guarantee DAHDIScan will work as it used to and DAHDIScan had to be integrated within chanspy (which really makes more sense to begin with, why should one app have to depend on another app).  So, there are some new features added into chanspy and extenspy that don't have to be there, but they're already written and shouldn't break anything.  The underling logic for these features will remain regardless if the user can set them or not, so I really don't see any reason not to include them. 
> 
> 
> Diffs
> -----
> 
>   /team/russell/ast_channel_ao2/apps/app_chanspy.c 189083 
> 
> Diff: http://reviewboard.digium.com/r/227/diff
> 
> 
> Testing
> -------
> 
> tested DAHDIScan, with and without groups, works as expected. 
> 
> 
> Thanks,
> 
> David
> 
>