[asterisk-dev] [Code Review] Makefile now specifies whether or not DAHDI hardware was found

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/216/#review716
-----------------------------------------------------------



/tools/trunk/xpp/dahdi_hardware
<http://reviewboard.digium.com/r/216/#comment1856>

    To keep the output of dahdi_hardware as parsable as possible, I prefer any free text message to begin with a '#'
    
    The line there is longer than 80 chars because the message is too long :-)  "# DAHDI devices found:\n"
    
    I would also prefer to just put the 'else' on the same line as the brace.


- Tzafrir


On 2009-04-17 16:00:26, dbrooks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/216/
> -----------------------------------------------------------
> 
> (Updated 2009-04-17 16:00:26)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a patch that allows the DAHDI Makefile to announce to the user whether or not it found DAHDI hardware. Prior to this patch, if DAHDI hardware was not found, "make config" would announce: "I think that the DAHDI hardware you have on your system is: " and stop there.
> 
> 
> This addresses bug 0014792.
>     http://bugs.digium.com/view.php?id=0014792
> 
> 
> Diffs
> -----
> 
>   /tools/trunk/Makefile 6374 
>   /tools/trunk/xpp/dahdi_hardware 6374 
> 
> Diff: http://reviewboard.digium.com/r/216/diff
> 
> 
> Testing
> -------
> 
> This patch was tested on x86_64-linux-gnu, and GNU Make 3.81.
> 
> 
> Thanks,
> 
> dbrooks
> 
>