[asterisk-dev] [Code Review] Autologoff when using AgentLogin

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/225/
-----------------------------------------------------------

(Updated 2009-04-17 09:18:43.717952)


Review request for Asterisk Developers.


Changes
-------

updated with Russell's comments.  persistent_agents code was removed because its called within agent_logoff_maintenance().


Summary
-------

Here's the scenario: An agent logs in by calling an extension that calls the AgentLogin app.  In agents.conf ackcall=always is set, so when they get a call they have the choice to either acknowledge it or ignore it.  autologoff=10 is set as well, so if the agent ignores the call over 10sec one may assume that the agent should be logged out (and in this case hungup on as well), but this does not happen.  

This patch makes autologout happen in this case.  Honestly, I have no idea why a user would want to set up agents like this, but there is a bug report for it.  Since its been like this forever, could this break expected behavior?

 


This addresses bug 14091.
    http://bugs.digium.com/view.php?id=14091


Diffs (updated)
-----

  /trunk/channels/chan_agent.c 188742 

Diff: http://reviewboard.digium.com/r/225/diff


Testing
-------

set up queue and agents.  Logged in as agent using AgentLogin.  Called into the queue on another line, never acknowledged the call on the agent, agent logged out and hung up after 10seconds, other call remained in queue.  Logged agent back in and acknowledged the call in queue, lines were bridged, hooray.    


Thanks,

David