[asterisk-dev] [Code Review] HTTP Digest authentication

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/223/#review704
-----------------------------------------------------------


I didn't make it all the way through the patch.  Please do a pass on the patch for both documentation and other coding guidelines issues.



/trunk/include/asterisk/http.h
<http://reviewboard.digium.com/r/223/#comment1826>

    This should probably return const.  Also, full doxygen documentation would be preferred.  (The full documentation comment applies to all new API calls in this patch.)



/trunk/include/asterisk/http.h
<http://reviewboard.digium.com/r/223/#comment1827>

    This is not a valid name for a new API call.  In fact, it's not even possible that using this would have worked unless you also updated the appropriate .export file.



/trunk/main/ast_expr2.h
<http://reviewboard.digium.com/r/223/#comment1828>

    Unrelated changes



/trunk/main/astobj2.c
<http://reviewboard.digium.com/r/223/#comment1829>

    I'm okay with this and the other changes to astobj2.c, but they should go in separately since they are not related to this functionality.



/trunk/main/http.c
<http://reviewboard.digium.com/r/223/#comment1830>

    This should probably just be const char text[]



/trunk/main/http.c
<http://reviewboard.digium.com/r/223/#comment1831>

    coding guielines



/trunk/main/http.c
<http://reviewboard.digium.com/r/223/#comment1832>

    coding guielines ...



/trunk/main/http.c
<http://reviewboard.digium.com/r/223/#comment1834>

    This is an important fact that should be in the ast_http_send() API docs


- Russell


On 2009-04-15 12:26:54, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/223/
> -----------------------------------------------------------
> 
> (Updated 2009-04-15 12:26:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Enable the use of HTTP Digest authentication when using the AMI HTTP interface.
> 
> 
> This addresses bug 10961.
>     http://bugs.digium.com/view.php?id=10961
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/http.h 188475 
>   /trunk/include/asterisk/utils.h 188475 
>   /trunk/main/ast_expr2.h 188475 
>   /trunk/main/astobj2.c 188475 
>   /trunk/main/http.c 188475 
>   /trunk/main/manager.c 188475 
>   /trunk/main/utils.c 188475 
>   /trunk/res/res_http_post.c 188475 
>   /trunk/res/res_phoneprov.c 188475 
> 
> Diff: http://reviewboard.digium.com/r/223/diff
> 
> 
> Testing
> -------
> 
> Lots of testing with fairly large files; all issues found were resolved.
> 
> 
> Thanks,
> 
> Tilghman
> 
>