[asterisk-dev] [Code Review] SIP state notify reorganization

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/224/#review703
-----------------------------------------------------------

Ship it!



/trunk/channels/chan_sip.c
<http://reviewboard.digium.com/r/224/#comment1823>

    doxygenify



/trunk/channels/chan_sip.c
<http://reviewboard.digium.com/r/224/#comment1824>

    constify mto and mfrom



/trunk/channels/chan_sip.c
<http://reviewboard.digium.com/r/224/#comment1825>

    These can be const


- Russell


On 2009-04-15 14:10:59, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/224/
> -----------------------------------------------------------
> 
> (Updated 2009-04-15 14:10:59)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> What I've done here is simply break up how a state NOTIFY is built.  It looks like a complicated diff but its really not.  Originally both the XML and sip header information were built within the same function.  While this does work, it does not allow for the creation of multipart/related message bodies that can contain multiple XML entries with only one sip header.  Now a separate function builds the XML for each notify.  This patch also makes maintaining and modifying state notifications in the future much less of a pain. 
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 188552 
> 
> Diff: http://reviewboard.digium.com/r/224/diff
> 
> 
> Testing
> -------
> 
> tested presence notifications with polycom 650.  everything works as expected. 
> 
> 
> Thanks,
> 
> David
> 
>